Allow flex justification controls to be disabled at the block level #67059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
tellthemachines
requested review from
Mamaduka,
talldan,
ramonjd,
ntsekouras and
aaronrobertshaw
|
Size Change: +11 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Code looks good to me, and setting "allowJustification": false in block.json toggles the controls in the toolbar and in the block settings sidebar
When settings "allowJustification": false in block.json:
| Trunk | This PR |
|---|---|
 |
 |
the sidebar will look a bit empty:
Better working than empty looking for now is my 2c!
| @@ -66,16 +66,19 @@ export default { | |||
| onChange, | |||
| layoutBlockSupport = {}, | |||
| } ) { | |||
| const { allowOrientation = true } = layoutBlockSupport; | |||
| const { allowOrientation = true, allowJustification = true } = | |||
There was a problem hiding this comment.
Just double checking the PR's description:
This PR updates the controls so they are only output when allowJustification is true.
Is it right that true is the default?
There was a problem hiding this comment.
Is it right that true is the default?
Yes!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
reviewed
Nov 18, 2024
| onChange={ onChange } | ||
| /> | ||
| </FlexItem> | ||
| ) } | ||
| <FlexItem> | ||
| { allowOrientation && ( |
There was a problem hiding this comment.
Can we not render FlexItem if ! allowOrientation? It was from before, but we can update it here.
There was a problem hiding this comment.
Yes, updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue noticed while reviewing #67022.
The
allowJustificationproperty of layout support should, per the docs allow disabling justification controls for the block in constrained or flex layouts, but currently flex justification controls are being rendered regardless of that property.This PR updates the controls so they are only output when
allowJustificationistrue.Testing Instructions
buttons/block.jsonupdate the layout support to:Note that if orientation controls are enabled (which they are by default), the sidebar will look a bit empty:
But that's already the case when justification is enabled and orientation is disabled (which has been a working feature for a while now):