ColorPicker: Update sizes of format select and copy button #67093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Nov 18, 2024
There was a problem hiding this comment.
Removing these button styles since they are no longer needed.
mirka
commented
Nov 18, 2024
| @@ -63,8 +63,8 @@ export const ColorCopyButton = ( props: ColorCopyButtonProps ) => { | |||
| copiedColor === color.toHex() ? __( 'Copied!' ) : __( 'Copy' ) | |||
| } | |||
| > | |||
| <CopyButton | |||
| size="small" | |||
| <Button | |||
There was a problem hiding this comment.
🚨 Unlabeled button alert, fix proposed in #67094.
tyxla
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite of #66898
What?
Updates the heights of the color format select and copy button in the ColorPicker component, so they both use the
compactsize.Why?
compactsize for the copy button is more aligned with the button size guidelines, and matches the latest component spec in Figma (cc @WordPress/gutenberg-design for awareness, no action necessary).Testing Instructions
See the Storybook story for ColorPicker.
Screenshots or screencast
Before
CleanShot.2024-11-19.at.07.54.10.mp4
After
CleanShot.2024-11-19.at.07.54.49.mp4