Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about required Core changes when updating minimum WordPress version #67167

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Nov 20, 2024

What?

When the minimum version of WordPress required for the plugin is raised, there is a change required in Core SVN to ensure the E2E test workflow does not break in any branch losing support with the version bump.

This adds a call out about this in the related section of the documentation.

Notes

This doesn't feel like the best place to add this, but wasn't sure about where to add a new page for "Raising minimum required version of WordPress". Most of this "Update the reference commit" section could be pulled out into that more general page, I think.

See Core Changeset 59221.

I've also gone and created Core-62488 to account for the bump in #67117.

Copy link

github-actions bot commented Nov 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <[email protected]>
Co-authored-by: ndiego <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Nov 20, 2024
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @desrosj!

@desrosj desrosj added [Type] Build Tooling Issues or PRs related to build tooling and removed [Type] Build Tooling Issues or PRs related to build tooling labels Nov 20, 2024
@desrosj desrosj enabled auto-merge (squash) November 20, 2024 16:56
@desrosj desrosj merged commit e4a716e into trunk Nov 20, 2024
65 of 66 checks passed
@desrosj desrosj deleted the add/wp-minimum-version-bump-steps branch November 20, 2024 17:27
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants