Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Add density option to table layout #67170

Merged
merged 7 commits into from
Nov 25, 2024
Merged

DataViews: Add density option to table layout #67170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12f6740
DataViews: Add density option to `table` layout
ntsekouras Nov 20, 2024
33863e4
rename PreviewSizePicker
ntsekouras Nov 21, 2024
e3e6352
rename var
ntsekouras Nov 21, 2024
c08fa7f
rename to `previewSize`
ntsekouras Nov 21, 2024
e41a211
do not update `view` on viewport change
ntsekouras Nov 25, 2024
2f533b8
Adjust spacing
jameskoster Nov 25, 2024
e657fc8
Fix bugs
jameskoster Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/edit-site/src/components/page-templates/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@

.dataviews-view-table & {
margin-bottom: $grid-unit-10;
display: block;
ntsekouras marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down
7 changes: 2 additions & 5 deletions packages/fields/src/fields/featured-image/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,10 @@ fieldset.fields-controls__featured-image {
}

.dataviews-view-table__cell-content-wrapper {
.fields-controls__featured-image-image {
width: 32px;
height: 32px;
}

.fields-controls__featured-image-image,
.fields-controls__featured-image-placeholder {
width: 32px;
height: 32px;
display: block;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous bug. The lack of display property was creating whitespace beneath the featured image which messed up alignment.

}
}
Loading