-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useBlockNameForPatterns: Refactor as a single useSelect call #67171
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -13 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
What?
Refactors a hook used by the Query block,
useBlockNameForPatterns
so as to make a singleuseSelect
call rather than two. This hook supports a feature introduced in #44197 that:Testing Instructions
Test the pattern selection modal in the Query block or the placeholder view, ensuring that there is no change in behaviour. When operating on a non-variation Query block instance, it should suggest regular query patterns, and when operating on a variation with registered patterns, it should suggest those. See #44197 for details.
I used the following patch to test, modified from the original PR to use
postType: 'post'
: