Composite: Restore Hover and Typeahead functionality
#67212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Nov 21, 2024
| @@ -26,5 +26,5 @@ export const CompositeHover = forwardRef< | |||
| // obfuscated to discourage its use outside of the component's internals. | |||
| const store = ( props.store ?? context.store ) as Ariakit.CompositeStore; | |||
|
|
|||
| return <Ariakit.CompositeGroup store={ store } { ...props } ref={ ref } />; | |||
| return <Ariakit.CompositeHover store={ store } { ...props } ref={ ref } />; | |||
mirka
changed the title
Hover and Typeahead functionality
|
Flaky tests detected in 9a319a3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11958943827
|
t-hamano
approved these changes
Nov 22, 2024
|
I think this PR is worth backporting to 6.7.2, so I'm adding the "Backport to WP Minor Release" label. |
t-hamano
added
the
Backport to WP Minor Release
cbravobernal
added a commit
that referenced
this pull request
Nov 24, 2024
* Composite.Typeahead: Restore functionality * Add changelog * Resurrect CompositeHover * Update changelog Co-authored-by: mirka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: im3dabasia <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: Mayank-Tripathi32 <[email protected]> Co-authored-by: jameskoster <[email protected]>
|
Lol. Thank you for having my back 🙏 |
cbravobernal
added a commit
that referenced
this pull request
Nov 25, 2024
…7.2 (#67258) * Composite: Restore `Hover` and `Typeahead` functionality (#67212) * Composite.Typeahead: Restore functionality * Add changelog * Resurrect CompositeHover * Update changelog Co-authored-by: mirka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: im3dabasia <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: Mayank-Tripathi32 <[email protected]> Co-authored-by: jameskoster <[email protected]> * Update changelog * Fix changelog --------- Co-authored-by: Lena Morita <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: im3dabasia <[email protected]> Co-authored-by: Mayank-Tripathi32 <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: Aki Hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67152
What?
Restores functionality of
Composite.HoverandComposite.Typeahead.How?
Due to a copy paste error in #65821, Typeahead functionality was lost and replaced with a CompositeRow, as well as Hover with CompositeGroup 😄
Testing Instructions
See repro instructions in #67152.