Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Increase option height #67214

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Autocomplete: Increase option height #67214

merged 2 commits into from
Nov 25, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 21, 2024

In preparation for #65751

What?

Increases the option height of the Autocomplete to align with the current sizing scheme.

Testing Instructions

In a Paragraph block in the Block Editor, type @ to start trigger the user autocomplete popover.

Screenshots or screencast

Before After
Autocompleter item, before Autocompleter item, after

@mirka mirka added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Nov 21, 2024
@mirka mirka self-assigned this Nov 21, 2024
@mirka mirka requested a review from ajitbohra as a code owner November 21, 2024 23:07
Copy link

github-actions bot commented Nov 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team November 21, 2024 23:07
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mirka mirka enabled auto-merge (squash) November 25, 2024 14:52
@mirka mirka merged commit e27e5e4 into trunk Nov 25, 2024
65 checks passed
@mirka mirka deleted the upsize-autocompleter-option branch November 25, 2024 14:56
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants