Always render metaboxes areas and use CSS to hide them when all panel are inactive #67228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Feature] Meta Boxes
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
afercia
changed the title
afercia
force-pushed
the
fix/metaboxes-post-request-when-hidden
branch
from
2d06fe7 to
7d9d113
Compare
|
In the last commit: when the Meta Boxes area is hidden, it shouldn't be a |
|
Noting that the 'MetaBoxVisibility' component ha sbeen refactored a few hours ago in #67265 although I think it's not directly relevant for this issue as the change is about code quality and doesn't change the behavior. Cc @stokesman @Mamaduka |
|
Closing in favor of #67254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67207
What?
WordPress 6.7 introduced a breaking change related to metaboxes where the 'normal' and 'advanced' metaboxes area don't render any HTML when all metaboxes panels are disabled in Preferences > General > Advanced.
Previously, the metaboxes HTML content was rendered and hidden with CSS.
Why?
Given the metaboxes content HTML is not rendered any longer, any form and hidden input fields used to save meta are not rendered as well. As such, Gutenberg will not fire a POST request to save those meta because the metaboxes areas are 'empty'.
How?
This PR attempts to restore the previous behavior by rendering the HTML anyways and hiding the content with CSS when all metaboxes panels are disabled in Preferences > General > Advanced.
Testing Instructions
POSTrequest topost.phpto save meta fields #67207Important:
Test the layout and expected behavior in various conditions for example with a viewport height less than 550 pixels. Test with other plugins that add metaboxes in teh normal and advanced areas.
Testing Instructions for Keyboard
Screenshots or screencast