Dashicons: Remove non-existent icons from type

[t-hamano]

What?

I noticed that there were two types of dashicons included that didn't have CSS defined, so I'm going to remove them.

https://github.com/t-hamano/wordpress-develop/blob/a27e6a8ecd5279a45e47ef88d048643740d07b5a/src/wp-includes/css/dashicons.css

Why?

Because these two icon strings don't display anything.

Testing Instructions

• Run npm run build:package-types
• In the icon prop below, enter the string this PR is trying to remove:
  

  gutenberg/packages/block-editor/src/components/block-variation-picker/index.js

  Lines 26 to 27 in b4c614f

  	<Placeholder
  	icon={ icon }

• Lists like the one below should not be displayed in this PR:
  
  

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Flaky tests detected in 79cd524.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11973642853
📝 Reported issues:

• [Flaky Test] submenu click on the arrow interactions #61884 in /test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js

[mirka]

I double-checked that the ids in the CSS file match the types. They match except for the manually added (?) ones at the end of the CSS file:

editor-distractionfree
exerpt-view
format-links
format-standard
post-trash
share1
welcome-edit-page

I don't know much about Dashicons and why these are "manually added" at the bottom, but those ids do seem to work as expected (as tested on Storybook). Maybe we should add them to the types as well?

[t-hamano]

Thanks for the review!

I don't know much about Dashicons and why these are "manually added" at the bottom, but those ids do seem to work as expected (as tested on Storybook). Maybe we should add them to the types as well?

These icons probably exist for backwards compatibility. There are equivalents to these icons.

• exerpt-view: This is a typo, the equivalent icon to this icon is excerpt-view.
• editor-distractionfree: Same as editor-expand icon (f211)
• format-links: Same as admin-links icon (f103)
• format-standard: Same as admin-post icon (f109)
• post-trash: Same as trash icon (f182)
• share1: Same as share icon (f237)
• welcome-edit-page: Same as welcome-write-blog icon (f119)

[mirka]

These icons probably exist for backwards compatibility

Ah ok, makes sense. Let's keep it out of the types then.