Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Manager: Make it a private component in the block editor package #67255

Merged
merged 2 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/base-styles/_z-index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ $z-layers: (
".components-resizable-box__corner-handle": 2,

// Make sure block manager sticky category titles appear above the options
".editor-block-manager__category-title": 1,
".block-editor-block-manager__category-title": 1,
// And block manager sticky disabled block count is higher still
".editor-block-manager__disabled-blocks-count": 2,
".block-editor-block-manager__disabled-blocks-count": 2,

// Needs to appear below other color circular picker related UI elements.
".components-circular-option-picker__option-wrapper::before": -1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function BlockManagerCategory( {
)
);

const titleId = 'editor-block-manager__category-title-' + instanceId;
const titleId = 'block-editor-block-manager__category-title-' + instanceId;

const isAllChecked = checkedBlockNames.length === blockTypes.length;
const isIndeterminate = ! isAllChecked && checkedBlockNames.length > 0;
Expand All @@ -80,13 +80,13 @@ function BlockManagerCategory( {
<div
role="group"
aria-labelledby={ titleId }
className="editor-block-manager__category"
className="block-editor-block-manager__category"
>
<CheckboxControl
__nextHasNoMarginBottom
checked={ isAllChecked }
onChange={ toggleAllVisible }
className="editor-block-manager__category-title"
className="block-editor-block-manager__category-title"
indeterminate={ isIndeterminate }
label={ <span id={ titleId }>{ title }</span> }
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
/**
* WordPress dependencies
*/
import { BlockIcon } from '@wordpress/block-editor';
import { CheckboxControl } from '@wordpress/components';

/**
* Internal dependencies
*/
import BlockIcon from '../block-icon';

function BlockTypesChecklist( { blockTypes, value, onItemChange } ) {
return (
<ul className="editor-block-manager__checklist">
<ul className="block-editor-block-manager__checklist">
{ blockTypes.map( ( blockType ) => (
<li
key={ blockType.name }
className="editor-block-manager__checklist-item"
className="block-editor-block-manager__checklist-item"
>
<CheckboxControl
__nextHasNoMarginBottom
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ export default function BlockManager( {
}, [ filteredBlockTypes?.length, search, debouncedSpeak ] );

return (
<div className="editor-block-manager__content">
<div className="block-editor-block-manager__content">
{ !! numberOfHiddenBlocks && (
<div className="editor-block-manager__disabled-blocks-count">
<div className="block-editor-block-manager__disabled-blocks-count">
{ sprintf(
/* translators: %d: number of blocks. */
_n(
Expand All @@ -88,16 +88,16 @@ export default function BlockManager( {
placeholder={ __( 'Search for a block' ) }
value={ search }
onChange={ ( nextSearch ) => setSearch( nextSearch ) }
className="editor-block-manager__search"
className="block-editor-block-manager__search"
/>
<div
tabIndex="0"
role="region"
aria-label={ __( 'Available block types' ) }
className="editor-block-manager__results"
className="block-editor-block-manager__results"
>
{ filteredBlockTypes.length === 0 && (
<p className="editor-block-manager__no-results">
<p className="block-editor-block-manager__no-results">
{ __( 'No blocks found.' ) }
</p>
) }
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
.editor-block-manager__no-results {
.block-editor-block-manager__no-results {
font-style: italic;
padding: $grid-unit-30 0;
text-align: center;
}

.editor-block-manager__search {
.block-editor-block-manager__search {
margin: $grid-unit-20 0;
}

.editor-block-manager__disabled-blocks-count {
.block-editor-block-manager__disabled-blocks-count {
border: $border-width solid $gray-300;
border-width: $border-width 0;
// Cover up horizontal areas off the sides of the box rectangle
Expand All @@ -19,43 +19,43 @@
position: sticky;
// When sticking, tuck the top border beneath the modal header border
top: ($grid-unit-05 + 1) * -1;
z-index: z-index(".editor-block-manager__disabled-blocks-count");
z-index: z-index(".block-editor-block-manager__disabled-blocks-count");

// Stick the category titles to the bottom
~ .editor-block-manager__results .editor-block-manager__category-title {
~ .block-editor-block-manager__results .block-editor-block-manager__category-title {
top: $grid-unit-40 - 1;
}
.is-link {
margin-left: 12px;
}
}

.editor-block-manager__category {
.block-editor-block-manager__category {
margin: 0 0 $grid-unit-30 0;
}

.editor-block-manager__category-title {
.block-editor-block-manager__category-title {
position: sticky;
top: - $grid-unit-05; // Offsets the top padding on the modal content container
padding: $grid-unit-20 0;
background-color: $white;
z-index: z-index(".editor-block-manager__category-title");
z-index: z-index(".block-editor-block-manager__category-title");

.components-checkbox-control__label {
font-weight: 600;
}
}

.editor-block-manager__checklist {
.block-editor-block-manager__checklist {
margin-top: 0;
}

.editor-block-manager__category-title,
.editor-block-manager__checklist-item {
.block-editor-block-manager__category-title,
.block-editor-block-manager__checklist-item {
border-bottom: 1px solid $gray-300;
}

.editor-block-manager__checklist-item {
.block-editor-block-manager__checklist-item {
display: flex;
justify-content: space-between;
align-items: center;
Expand All @@ -72,11 +72,11 @@
}
}

.editor-block-manager__results {
.block-editor-block-manager__results {
border-top: $border-width solid $gray-300;
}

// Remove the top border from results when adjacent to the disabled block count
.editor-block-manager__disabled-blocks-count + .editor-block-manager__results {
.block-editor-block-manager__disabled-blocks-count + .block-editor-block-manager__results {
border-top-width: 0;
}
1 change: 1 addition & 0 deletions packages/block-editor/src/content.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import "./components/block-icon/content.scss";
@import "./components/block-list/content.scss";
@import "./components/block-list-appender/content.scss";
@import "./components/block-manager/style.scss";
ramonjd marked this conversation as resolved.
Show resolved Hide resolved
@import "./components/block-content-overlay/content.scss";
@import "./components/block-draggable/content.scss";
@import "./components/block-preview/content.scss";
Expand Down
2 changes: 2 additions & 0 deletions packages/block-editor/src/private-apis.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { useHasBlockToolbar } from './components/block-toolbar/use-has-block-too
import { cleanEmptyObject } from './hooks/utils';
import BlockQuickNavigation from './components/block-quick-navigation';
import { LayoutStyle } from './components/block-list/layout';
import BlockManager from './components/block-manager';
import { BlockRemovalWarningModal } from './components/block-removal-warning-modal';
import {
setBackgroundStyleDefaults,
Expand Down Expand Up @@ -71,6 +72,7 @@ lock( privateApis, {
cleanEmptyObject,
BlockQuickNavigation,
LayoutStyle,
BlockManager,
BlockRemovalWarningModal,
useLayoutClasses,
useLayoutStyles,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@ import { useSelect, useDispatch } from '@wordpress/data';
import { store as preferencesStore } from '@wordpress/preferences';
import { hasBlockSupport, store as blocksStore } from '@wordpress/blocks';
import { useMemo } from '@wordpress/element';
import { privateApis as blockEditorPrivateApis } from '@wordpress/block-editor';

/**
* Internal dependencies
*/
import { store as editorStore } from '../../store';
import { unlock } from '../../lock-unlock';
import BlockManager from '../block-manager';

const { BlockManager } = unlock( blockEditorPrivateApis );

export default function BlockVisibility() {
const { showBlockTypes, hideBlockTypes } = unlock(
Expand Down
1 change: 0 additions & 1 deletion packages/editor/src/style.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@import "../../interface/src/style.scss";

@import "./components/autocompleters/style.scss";
@import "./components/block-manager/style.scss";
@import "./components/collab-sidebar/style.scss";
@import "./components/collapsible-block-toolbar/style.scss";
@import "./components/create-template-part-modal/style.scss";
Expand Down
Loading