Fix block mover clickable area #67261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +10 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b3ec803. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12003902485
|
ramonjd
approved these changes
Nov 25, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @maximebj. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
For the reasons stated above, and because of how widely used the
In principle, this seems like a good idea, given that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #67239
How?
Applies
overflow: hiddento the mover<button>so that the inner<svg>element can't overlap other parts of the UI.We may also want to consider a fix fore this in the components package (cc @WordPress/gutenberg-components). It's a bit of a gray area since the mover buttons modify the general
Buttoncomponent quite a bit making the<button>smaller than normal and moving the position of the<svg>. I decided to try and get this one liner merged first, since it's a bad bug.(also, I wonder if the mover buttons should be using
ToolbarButtoninstead of plain oldButton)Testing Instructions
In trunk: The block moves down
In this PR: The block moves up as it should
Screenshots or screencast
Before
Kapture.2024-11-25.at.13.21.24.mp4
After
Kapture.2024-11-25.at.13.23.44.mp4