Edit Post: Remove unused 'hasHistory' flag #67293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -23 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
I guess if this has been working ok, then it's fine to remove it!
I don't really know what the ! hasHistory condition in <BrowserUrl> was intended for originally, and I mentioned it in the review back then. I still don't know to this day, but I approved it, so I must have forgotten about it 😓
|
It disabled the behavior of However, even after reading the original PR, I'm unsure how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes the unused
hasHistoryflag for theBrowserURLcomponent. It was introduced via #57036, but the store has returned no value since #62339.Testing Instructions
None. CI checks should be green.