Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components contributing guide: Fix relative links #67323

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 26, 2024

What?

Fixes relative links in the Components Contributing Guide that break in certain contexts.

(Props @juanbuis for reporting)

Why?

When embedded as part of the Storybook, a lot of relative links to certain Markdown docs in the repo break.

Testing Instructions

Go to Components ▸ Contributing Guidelines in the Storybook and check that there are no broken links due to relative linking.

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components Storybook Storybook and its stories for components labels Nov 26, 2024
@mirka mirka self-assigned this Nov 26, 2024
@mirka mirka requested a review from ajitbohra as a code owner November 26, 2024 17:00
@mirka mirka requested a review from a team November 26, 2024 17:01
Copy link

github-actions bot commented Nov 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mirka mirka merged commit 8656f12 into trunk Nov 26, 2024
71 of 72 checks passed
@mirka mirka deleted the fix/components-contrib branch November 26, 2024 19:24
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants