Fix color of disabled buttons in dark toolbar #67348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
dark-toolbar-color
branch
from
d0f3ff6 to
9bb442f
Compare
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +30 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Do we use a low opacity in other contexts? I guess not, no, but it might have been nice to use opacities here, as it would work across any theme color. That could be something to explore in the future, where a 3rd party component consumer might feed a different color primary button into the system. |
jasmussen
approved these changes
Nov 27, 2024
|
Thanks for the review!
There doesn't seem to be a consistent rule on this within the Gutenberg project. For now, the dark toolbar background color is fixed at I'd like to merge this PR, but will address it in a follow-up if necessary. |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: jasmussen <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #66116
What?
Provides visual differentiation between disabled buttons on dark toolbars.
Why?
Regardless of whether the button is enabled or disabled, the color remains the same (
$gray-300), making it visually impossible to tell whether the button is disabled or not.How?
I chose
$gray-700, but the color we chose is up for debate.If the color is too dark it will blend in with the background color, and if the color is too light it will be indistinguishable from a normal button. If none of the colors are suitable, we can also apply opacity instead of color.
$gray-800$gray-700$gray-600$gray-400Testing Instructions
Screenshots or screencast
Before
After