Edit Site: Fix block styles navigation error #67375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
tyxla
requested review from
draganescu,
youknowriad,
jsnajdr,
jeryj and
ajlende
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1 task
|
How is this related to the PR, did you figure that out? |
|
Size Change: +15 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f96e2e3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12065744918
|
|
I cannot reproduce this error. Merely loading the The current fix seems to be merely hiding the real problem. We probably shouldn't reach the code path that calls By the way, the I'm escaping the unwanted slash inside |
There's definitely something to improve here but it's not clear to me yet whether the current sections should be the paths or not. |
|
I'm a bit time-limited, so I'm unable to debug deep today and see why this code path is reached. This was a quick fix, not specifically targeted at the root cause. I'm happy to accept a better solution, but in the meantime, this bug prevents me from loading screens with global styles of any particular block, thus the quick fix. Navigating to that screen is fine FWIW. |
|
First observations: I think this is messed up: gutenberg/packages/block-editor/src/components/iframe/use-scale-canvas.js Lines 289 to 303 in eadf2dd This effect assumes that it will run only when zoomed out mode is toggled, but that's not the case. It's also run during initial render even when we're not toggling zoomed out mode, which seems to mess things up. cc @jeryj |
github-actions
bot
added
the
[Status] In Progress
|
Closing in favor of #67481 which addresses the actual issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an error that occurs when navigating directly to block styles in the site editor.
Why?
Just fixing an error that seems to have been introduced in #66917.
Found while testing #67199.
How?
We're checking if the animation has a timeline before attempting to reverse it.
Testing Instructions
/wp-admin/site-editor.php?p=%2Fstyles§ion=%2Fblocks%2Fcore%252FheadingTesting Instructions for Keyboard
Same
Screenshots or screencast