Edit Site: Fix sidebar template author navigation #67382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
1 task
|
Size Change: +3 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 28, 2024
| @@ -25,7 +26,7 @@ function TemplateDataviewItem( { template, isActive } ) { | |||
|
|
|||
| return ( | |||
| <SidebarNavigationItem | |||
| to={ `/template?activeView=${ text }` } | |||
| to={ addQueryArgs( '/template', { activeView: text } ) } | |||
There was a problem hiding this comment.
I don't undestand what's the difference between the two codes?
There was a problem hiding this comment.
Basically, URL encoding.
The version in trunk will navigate to:
/template?activeView=Twenty Twenty-Four
while the version here will navigate to:
/template?activeView=Twenty%20Twenty-Four
and the former seems to break the navigation.
There was a problem hiding this comment.
Shipping this one, but it might make sense to double-check other instances where we hardcoded the query string instead of using addQueryArgs().
Cases like this are exactly why I was suggesting defaulting to addQueryArgs() FWIW.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Nov 28, 2024
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: tyxla <[email protected]> Co-authored-by: youknowriad <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: tyxla <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the template author sidebar navigation which regressed in #67199.
Why?
We slightly broke it in #67199 - clicking on a template author to filter templates is not working right now.
How?
We're using
addQueryArgs()to properly deal with the existing query while adding the filter args.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast