Site Editor: Fix the patterns route on mobile #67467
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 2, 2024
6 tasks
|
Can we also fix the browser console error on navigation? This also appears to be a result of #67199. 9ed79344ca0cdccfc020dfb57a67bbd8.mp4Additionally, it might be a good idea to explore #67505 as a follow-up to this PR (See this comment). |
|
I'm not sure that JS error is related to the refactoring, it might be related to the refactoring of the sidebar done a long time ago to avoid the Navigation component. cc @jsnajdr |
I think the JS error ( gutenberg/packages/edit-site/src/components/layout/index.js Lines 149 to 161 in 5c76815 which renders It seems that it was really #67199 that broke this, namely the changes in "home route". The old version rendered |
|
Feels like |
However, the It would be better if the I think that @oandregal is the main expert in this area 🙂 Another questions is: if the Maybe we should fix the mobile sidebar layout code. The part that renders |
I found similar yesterday, and tested rendering the area inside and outside SidebarContent in #67505 as a quick fix. The error pops up for most sidebar navigation in mobile, e.g., #67532 |
ramonjd
added a commit
that referenced
this pull request
Dec 4, 2024
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ramonjd <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67460
What?
Fix a small regression preventing patterns access on mobile.
Testing Instructions
1- Open the site editor on mobile
2- Click "patterns"
You should see the grid of patterns.