19.8 Edit Site: styles nav item does not open on mobile for themes without style variations #67550
+10
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m in the edit site sidebar. Also, move its uid prop to MainSidebarNavigationContent for consistency and convenience. Why? When a block theme lacks global style variations, the top-level Styles panel in the Site Editor does not open on mobile. The sidebar navigation styles item now contains the global styles UI and no longer just the variations so the `hasGlobalStyleVariations` causes the bug and is, also, redundant.
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -34 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 98a482b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12153591757
|
talldan
approved these changes
Dec 4, 2024
|
Thanks a lot for testing @aaronrobertshaw
The Cheers! |
Thanks @talldan Funny you should mention that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #67532 for 19.8
hasGlobalStyleVariationscondition to show the Styles menu item in the edit site sidebar.uidprop toMainSidebarNavigationContentfor consistency and convenience.Why a hotfix for this branch?
Since #67199 a few things have changed in trunk so this PR targets the state of 19.8 only.
In trunk this bug has been fixed by the following PRs:
hasGlobalStyleVariationscondition for the Styles nav item #67545Why?
BUG! When a block theme doesn't have style variations, the newer experience for top level styles in the Site Editor does not open on mobile.
The sidebar navigation styles item now contains the global styles UI and no longer just the variations. For this reason it's okay to remove the condition.
Testing Instructions
Screenshots or screencast
Kapture.2024-12-04.at.16.19.37.mp4