-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Fix filters lost when switching layouts #67740
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
isCustom, | ||
editEntityRecord, | ||
editedEntityRecord?.id, | ||
layout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug was the presence of "layout" in this hook which caused the "view" to reset even if we didn't want it to.
I refactored the code to use useEvent which means these depenedencies are not needed unless we really want them.
I think it's easier to read now.
Size Change: +21 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Flaky tests detected in 5c561f0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12236786272
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I've added an e2e test to prevent this regression from happening again. I'll do the same for templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Related #55083
What?
When switching layouts in the "pages" (or posts) dataviews, the filters, sorting... is lost. This PR fixes that.
The bug is still present for the moment in the templates dataviews (which I will tackle as well)
Testing Instructions
1- Open the "pages" dataviews
2- Apply some random filter
3- Switch the layout
4- The filter should persist.