Update bulk header with actions #67743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwie17
added
[Type] Enhancement
louwie17
commented
Dec 9, 2024
There was a problem hiding this comment.
Remove header file created in previous PR: #67390
louwie17
commented
Dec 9, 2024
| export default function PostActions( { postType, postId, onActionPerformed } ) { | ||
| const [ activeModalAction, setActiveModalAction ] = useState( null ); | ||
| const { item, permissions } = useSelect( | ||
| function useEditedEntityRecordsWithPermissions( postType, postIds ) { |
There was a problem hiding this comment.
Moved this logic to its own hook. It gets all the edited records and adds permissions.
It's similar to this hook:
edited records specifically.
Would it be worth moving to the core-data package as well?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
louwie17
requested review from
youknowriad,
oandregal,
gigitux and
ntsekouras
youknowriad
reviewed
Dec 9, 2024
| postId={ | ||
| ids.length === 1 ? parseInt( ids[ 0 ], 10 ) : undefined | ||
| } | ||
| postIds={ ids.length > 1 ? ids : undefined } |
There was a problem hiding this comment.
Can this be just postId prop and accept an array or a scalar there?
There was a problem hiding this comment.
Yeah that works for me, I chose postIds for clarity, but for consumers a single prop would be easier.
|
Size Change: -94 B (-0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 9, 2024
| itemsWithPermissions.some( ( itemWithPermissions ) => | ||
| action.isEligible( itemWithPermissions ) | ||
| ) ) && | ||
| ( itemsWithPermissions.length < 2 || action.supportsBulk ) |
There was a problem hiding this comment.
Remark: Some of this logic and the UI component itself to render the actions dropdown... is already present in the DataViews package. It seems like instead of duplicating all of that, we should be exposing a DataActions component from the DataViews package :)
There was a problem hiding this comment.
Yes that would make sense, as there is a lot of duplication. But it appears this was also done on purpose, given this inline comment:
https://github.com/WordPress/gutenberg/blob/trunk/packages/editor/src/components/post-actions/index.js#L88-L91
From now on all the functions on this file are copied as from the dataviews packages,
The editor packages should not be using the dataviews packages directly,
and the dataviews package should not be using the editor packages directly,
so duplicating the code here seems like the least bad option.
Should we still go ahead with this, or is there a specific reason these packages can't depend on each other?
There was a problem hiding this comment.
I don't understand why the editor shouldn't be using dataviews package.
(Regardless, this should be a follow-up and not block this PR from shipping)
Mamaduka
reviewed
Dec 10, 2024
Comment on lines
+29
to
+33
| items: postIds.map( ( postId ) => | ||
| getEditedEntityRecord( 'postType', postType, postId ) | ||
| ), | ||
| permissions: postIds.map( ( postId ) => | ||
| getEntityRecordPermissions( 'postType', postType, postId ) |
There was a problem hiding this comment.
This change has a couple of issues:
- Iterating over values here results in different
itemsandpermissionsarrays on everymapSelectcall. - Technically, it can also result in multiple HTTP calls if entity data isn't available in the store.
You can fetch permissions for multiple entities using getEntityRecordsPermissions, but we don't have a similar substitute for getEditedEntityRecord. The getEntityRecords could work but will trigger a REST API request for each new post selection in DataViews.
Screenshot
There was a problem hiding this comment.
Thanks @Mamaduka, will push up a fix for this today.
There was a problem hiding this comment.
Followed up in this PR: #67872
There was a problem hiding this comment.
Thanks, @louwie17; I'll have a look later today or tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As part of #67390 I introduced a specific header component to handle the bulk view. Given the logic overlaps with the
PostCardPanelespecially around the actions, it was suggested to update thePostCardPanelto handle multiple post ids.This PR updates the
PostCardPanelcomponent to support multiple postIds.Why?
This allows us to re-use it fully within the DataViews quick edit.
How?
I added an extra prop to the
PostCardPanelcalledpostIds. This will update the title to<number> <post type>and update the actions to only show the ones that supportbulkActions.Testing Instructions
Move to trashactionPagetab in the editing settings menu ( on the far right )Testing Instructions for Keyboard
Screenshots or screencast
bulk-editing-with-actions.mp4