Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Block: Refactor settings panel to use ToolsPanel #67905

Merged

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Dec 13, 2024

Part of: #67813
Fixes: #67926

What?

Refactored More Block code to include ToolsPanel instead of PanelBody.

Screenshots

Trunk In this PR
image Screenshot 2024-12-13 at 10 39 48 AM Screenshot 2024-12-13 at 10 40 00 AM

@im3dabasia im3dabasia marked this pull request as ready for review December 13, 2024 09:06
Copy link

github-actions bot commented Dec 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] More Affects the More Block - used for displaying the 'Read More' link labels Dec 13, 2024
@im3dabasia im3dabasia requested a review from Mamaduka December 16, 2024 07:19
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @im3dabasia!

The migration works as expected ✅

@Mamaduka Mamaduka merged commit 5b7926b into WordPress:trunk Dec 16, 2024
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 16, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] More Affects the More Block - used for displaying the 'Read More' link [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of More block to use ToolsPanel instead of PanelBody
3 participants