Add a basic test for shortcode transformation #7823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
added
[Type] Automated Testing
mcsf
reviewed
Jul 9, 2018
| isValid: true, | ||
| name: 'core/shortcode', | ||
| uid: transformed[ 1 ].uid, | ||
| }; |
There was a problem hiding this comment.
Should use createBlock instead of crafting the final object, so we're only testing the converter (and not tying any future structure changes to this test).
There was a problem hiding this comment.
Good suggestion, updated in b90feeb
| expect( transformed[ 1 ] ).toEqual( expectedBlock ); | ||
| expect( transformed[ 2 ] ).toBe( ` | ||
|
|
||
| <p>Bar</p>` ); |
There was a problem hiding this comment.
Minor, but I'd .trim() the values transformed[ 0 ] and transformed[ 2 ] and test against just <p>…</p>.
There was a problem hiding this comment.
I'd prefer not to use .trim(), as I think whitespace should be a part of the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #7689
See #7030, #4456