-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages: Extract viewport package #7975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward 👍
@@ -0,0 +1,34 @@ | |||
{ | |||
"name": "@wordpress/viewport", | |||
"version": "1.0.0-alpha.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's not that important but I thought we were using -beta.0 for the first unpublished versions. Since we publish stable versions directly, it's not very important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are going to publish 1.0.0
later this week for all packages to make publishing with 2FA maintinanable 😄
I think this may have broken
|
Right, I should remove it from yet another list of non-package modules 😃 And also path to store folder is outdated now. |
Part of #3955.
This PR moves
viewport
module topackages
folder and converts it to npm package maintained by Lerna. It's mostly boils down to moving files. In addition, I had to addpackage.json
file and a few small adjustments to the existing setup.There are NO breaking changes
I also added a few unrelated changes where I discovered that we didn't list dev dependencies in other packages.
Testing instructions