Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Update test for babel-preset-default #7985

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Testing: Update test for babel-preset-default #7985

merged 1 commit into from
Jul 18, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jul 16, 2018

Description

This PR updates test for babel-preset-default package to be snapshot based to ensure that transpilation works as expected. This new approach was suggested by @aduth over the existing test case.

How has this been tested?

npm test

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Tool] Babel preset /packages/babel-preset-default labels Jul 16, 2018
@gziolo gziolo added this to the 3.3 milestone Jul 16, 2018
@gziolo gziolo self-assigned this Jul 16, 2018
@gziolo gziolo requested review from aduth and a team July 16, 2018 15:34
aduth
aduth approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really recall the original context for this one, but it seems like a strange and tedious thing to test. That said, what's here is better than what we have.

@aduth aduth modified the milestones: 3.3, 3.4 Jul 18, 2018
@gziolo gziolo merged commit 7ab5a9e into master Jul 18, 2018
@gziolo gziolo deleted the update/babel-preset-test branch July 18, 2018 19:31
@aduth aduth modified the milestones: 3.4, 3.3 Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees

@gziolo gziolo

Labels
[Tool] Babel preset /packages/babel-preset-default [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @aduth