Rename Shared Blocks to Reusable Blocks #8123
Conversation
noisysocks
added
the
[Feature] Synced Patterns
|
Can we go with Reusable? Ideally saying 'Save this block to reuse' as the call? Apologies but I think this would work better going forward @noisysocks based on feedback in that issue. |
gziolo
added
the
[Type] Breaking Change
|
There are some changes to public selectors and actions, should we add deprecation note? |
noisysocks
force-pushed
the
update/rename-shared-blocks
branch
from
ded10a6 to
bc2d765
Compare
noisysocks
changed the title
|
I've updated this to use 'reusable', changed the copy of the UI controls to match what Kjell suggested in #7887 (comment), and added deprecated aliases for the public selectors, actions and block API. |
noisysocks
force-pushed
the
update/rename-shared-blocks
branch
from
bc2d765 to
60159dd
Compare
| role={ itemsRole } | ||
| > | ||
| { __( 'Delete Shared Block' ) } | ||
| { __( 'Remove from Reusable Blocks' ) } |
There was a problem hiding this comment.
This one is a bit confusing to me. I understand better "Remove reusable block" but I can see how the ambiguity there too.
Change reusable block button copy so that 'reusable blocks' are treated as a collection that blocks are added to or removed from.
noisysocks
force-pushed
the
update/rename-shared-blocks
branch
from
60159dd to
7e44002
Compare
|
Gonna merge this to get ahead of merge conflicts 🙂 – can change the copy later if @karmatosed isn't OK with it. |
|
Any deprecations should be added to https://wordpress.org/gutenberg/handbook/reference/deprecated/ The functions deprecated here do not appear there and thus plugin authors who reference this page would not have the advance notice to have updated their usage. |
| return updateReusableBlockTitle( id, title ); | ||
| } | ||
|
|
||
| export function convertBlockToSaved( clientId ) { |
There was a problem hiding this comment.
This function was called convertBlockToShared, not convertBlockToSaved.
This is the first half of #7887.
Renames all 'shared block' references to 'reusable block', and changes the copy of the associated UI controls to match what was suggested in #7887 (comment).
To test: