DOM: Restore horizontal edge traversal implementation #8461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Rich Text
This was referenced Aug 3, 2018
Closed
youknowriad
approved these changes
Aug 6, 2018
aduth
force-pushed
the
fix/newline-backspace
branch
from
159e204 to
48a16ab
Compare
|
This caused a regression #8731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8306 (cherry-picks c363a87)
Regression introduced in #7877
Fixes #8388
This pull request seeks to resolve an issue where pressing Backspace may not place the caret in the correct position if within or after a RichText field which includes newlines. This is a flaw of the updated implementation implementation included in #7877 which uses
Range#toStringandNode#textContent, both of which produce unreliable results when including abrelement.The changes here reintroduce the original implementation authored by @iseulde , with some explanatory comments. It cherry-picks the once-failing test from @pento , originally committed in #7877.
Testing instructions:
Ensure end-to-end tests pass: