Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the Autosaves controller, even if revisions are disabled #8682

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

adamsilverstein
Copy link
Member

@adamsilverstein adamsilverstein commented Aug 7, 2018

Description

Fixes #8536
Fixes #7442
Fixes #7348

Revisions are not required to support autosaves - see https://codex.wordpress.org/Revisions#Revision_Options

How has this been tested?

I verified the endpoint shows up even with revisions disabled for a post type.

Types of changes

Removed the check for revision post type support when loading the autosaves controller.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@danielbachhuber danielbachhuber added the [Feature] Saving Related to saving functionality label Aug 7, 2018
@danielbachhuber danielbachhuber added this to the 3.5 milestone Aug 7, 2018
@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended REST API Interaction Related to REST API labels Aug 7, 2018
@danielbachhuber danielbachhuber merged commit 17852d6 into master Aug 7, 2018
@danielbachhuber danielbachhuber deleted the fix/autosaves-without-revisions branch August 7, 2018 21:32
@danielbachhuber
Copy link
Member

Worth noting: I tested this independently in #8692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality REST API Interaction Related to REST API [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants