Framework: Remove deprecations slated for 3.5 removal #8687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
tofumatt
approved these changes
Aug 7, 2018
| if ( this.props.onSelectURL ) { | ||
| this.props.onSelectURL( this.state.src ); | ||
| } | ||
| if ( this.state.src && this.props.onSelectURL ) { |
There was a problem hiding this comment.
The comment above is a bit unclear to me, but seems to imply we shouldn't (need to) check for truthiness of onSelectUrl. It says it's required for this function to run, so do we still want to check for it?
There was a problem hiding this comment.
I double checked this one and how it is used, this prop is optional, it is good as is.
| @@ -120,7 +100,7 @@ class MediaPlaceholder extends Component { | |||
| onFilesDrop={ this.onFilesUpload } | |||
| onHTMLDrop={ onHTMLDrop } | |||
| /> | |||
| { ( onSelectUrl || onSelectURL ) && ( | |||
| { onSelectURL && ( | |||
There was a problem hiding this comment.
Right, based on this the function above should error if called without onSelectURL being specified.
There was a problem hiding this comment.
won't it silently skip this branch?
| @@ -242,27 +241,4 @@ class URLInput extends Component { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: As part of deprecation of UrlInput, the temporary passthrough | |||
There was a problem hiding this comment.
Thanks to whomever wrote these deprecation comments, because they make reviewing this code removal very straightforward 👍
gziolo
force-pushed
the
remove/3-5-deprecations
branch
from
091f841 to
f396173
Compare
gziolo
added
the
[Type] Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecations scheduled to be removed in the upcoming 3.5.0 release.
This includes a few updates to core code which was still using deprecated functions (see #7895, #7947).
Source: https://wordpress.org/gutenberg/handbook/reference/deprecated/#3-4-0