-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Introduce left and right float alignment options to latest posts block #8814
[Enhancement] Introduce left and right float alignment options to latest posts block #8814
Conversation
Looks like the left and right float alignments are working in both editor and front-end to me! Notably, however, the center alignment option is still applied by default for some reason. That bug is tracked in #7911; if you could fix that in this PR, that would be great, but this is already an improvement over |
Thank you @ZebulanStanphill ❤️ I've submitted #8847 for #7911. |
@nfmohit-wpmudev, I'm unable to get this to run at this point — probably needs a rebase. From a design perspective, the mockup you have above (adding those two standard alignment buttons to the block toolbar) is the right thing to do, so I'm going to remove the |
@nfmohit-wpmudev @kjellr I forgot about this PR and made my own PR adding all alignment options to all widget blocks. But anyway, in case that PR is rejected or something, here is what you need to do to get this PR working: You need to modify |
I don't know why it wasn't running before, but it's alright now. I can verify that those buttons are showing up. Thanks @nfmohit-wpmudev! 👍 Since there's another PR open (#9557) that also adds those buttons, we should hold off on merging until we know the status of that one too. |
@kjellr @nfmohit-wpmudev I am splitting #9557 into several smaller PRs, starting with #9696. Feel free to merge this once you have fixed the issues mentioned above. |
@ZebulanStanphill Thank you for the heads up bud ❤️ Don't you think including the |
@nfmohit-wpmudev It seems like a typo to me, but I am fine if you leave it out of this PR and someone addresses it in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, changes look good 👍 Thanks for contribution.
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: Try alternate list item jump fix. (#12941) Mobile bottom sheet component (#13612) Remove unintentional right-margin on last odd-item. (#12199) Introduce left and right float alignment options to latest posts block (#8814) Fix Google Docs table paste (#13543) Increase bottom padding on gallery image caption (#13623) Fix the editor save keyboard shortcut not working in code editor view (#13159) Plugin: Deprecate gutenberg_add_admin_body_class (#13572) Rnmobile/upload media failed state (#13615) Make clickOnMoreMenuItem not dependent on aria labels (#13166) Add: className prop support to server side render. (#13568) Fix: Categories Block: hierarchical Dropdown (#13567) Docs: Add clarification about git workflow (#13534) Plugin: Remove `user_can_richedit` filtering (#13608) eslint-plugin: Add rule `no-unused-vars-before-return` (#12828) Image settings button (#13597) Fixed wording for the color picker saturation (#13479) # Conflicts: # packages/block-library/src/image/edit.native.js
Description
This PR closes #8777 which request the availability of left and right float alignment options in the Latest Posts block, making it consistent like the Archive, Latest Comments, and Categories blocks.
How has this been tested?
This PR has been tested by going through the following steps:
This was tested in WP 4.9.8, Gutenberg 3.5.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.
Screenshots
Types of changes
This PR just omits the
controls
property in the block alignment toolbar of the Latest Posts block, which specified thecenter
,wide
, andfull
alignments, excluding theleft
andright
ones.Checklist: