Check required fields in media store

[stacimc]

Fixes

Fixes WordPress/openverse#1281 by @stacimc

Description

This PR:

• raises a ValueError in the MediaStore's clean_media_metadata if any of the required fields foreign_landing_url, url, and foreign_identifier are missing.
• Adds some new error handling for Metropolitan:
  • Returns early if no image urls (primary or additional) can be pulled
  • Handles missing isPublicDomain key (in addition to explicit False)
  • Returns early if missing foreign landing url

Testing Instructions

View the new tests.

The Metropolitan issue is hard to reproduce organically. You can manually update the metropolitan DAG code to add a None image here:

        image_list = [main_image] + other_images + [None]

Then run the DAG and ensure that you do not see any errors (because no records with None url are passed to the MediaStore).

You can test that the error handling in the media store is working by hard-coding None for one of the required fields in the results here. Then you should see the task fail when you run the DAG, with an error message like:

Record missing required field: `foreign_landing_url`

Checklist

• My pull request has a descriptive title (not a vague title like
  Update index.md).
• My pull request targets the default branch of the repository (main) or
  a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible
  errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[krysal]

I can't believe this wasn't checked before 😱 Well noticed. However, I wonder whether just ignoring items when missing fields at this point, in the media store class, is the right approach. I am slightly inclined to raise an exception here and have each provider DAG handle theses cases explicitly. Sometimes, if a field is not found another from the source can be used in replacement, e.g. this is common in the creator_url. These errors have also helped me realize some gaps in the logic in a few cases!

What do you think?

[stacimc]

Sometimes, if a field is not found another from the source can be used in replacement, e.g. this is common in the creator_url

That's a really great point -- raising an exception here might help us spot these opportunities in some cases, and even in cases where the record should ultimately be discarded, it'll be an easy fix in the provider class. I'll update!

[krysal]

Following my previous comment, shouldn't we also add the field validations in the Metropolitan DAG? It could skip processing for more than one image, cutting times a bit.

[AetherUnbound]

I like what y'all have proposed & discussed! Given how rapidly we are able to iterate on ingestion DAGs, I like the idea of failing sooner and addressing issues on a per-provider basis. That, in its own way, can serve as a data health check - if the data changes and our assumptions no longer hold, we want to know about it.

I have one logging suggestion which is blocking, but otherwise this looks great!

[AetherUnbound]

Nice!

[AetherUnbound]

LGTM! 😄

[zackkrida]

Looks great!