This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Default unfurling of links and media to False in Slack notifications #743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
Recent provider DAG errors have caused notifications containing images to be sent to Slack. @sarayourfriend pointed out that while these messages have historically been harmless, it's possible that this could happen with NSFW content.
This PR updates our Catalog Slack utility to not unfurl links or media by default.
Testing Instructions
Go through the current uses of
send_message
andsend_alert
and verify that there are no use cases where we definitely want media and/or links to be unfurled.For further manual testing, I'm not sure how to force a Slack message with an image 🤔
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin