Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Default unfurling of links and media to False in Slack notifications #743

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Sep 27, 2022

Fixes

Description

Recent provider DAG errors have caused notifications containing images to be sent to Slack. @sarayourfriend pointed out that while these messages have historically been harmless, it's possible that this could happen with NSFW content.

This PR updates our Catalog Slack utility to not unfurl links or media by default.

Testing Instructions

Go through the current uses of send_message and send_alert and verify that there are no use cases where we definitely want media and/or links to be unfurled.

For further manual testing, I'm not sure how to force a Slack message with an image 🤔

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Sep 27, 2022
@stacimc stacimc requested a review from a team as a code owner September 27, 2022 01:15
@stacimc stacimc self-assigned this Sep 27, 2022
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine wanting to have links unfurled for any of our current use cases. Thanks for doing this! We should also have another PR for the ingestion server to disable it there too 💯

@stacimc
Copy link
Contributor Author

stacimc commented Sep 27, 2022

Agreed! I opened WordPress/openverse-api#954 in the API to track that -- should be an extremely quick one. I'm planning on grabbing it tomorrow if no one else does :)

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stacimc stacimc merged commit 3b58e60 into main Sep 28, 2022
@stacimc stacimc deleted the update/slack-notifs-to-not-unfurl-media-by-default branch September 28, 2022 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants