-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this in the initial review, but the more I think about it the CI/CD workflows should only cancel in progress for pull requests. We might want to make this change to all the CI/CD workflows for the other repos as well. What do y'all think @WordPress/openverse-maintainers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me :) Thanks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think only cancelling in-progress for PRs makes a lot of sense, as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks, @alrz1999!
Fixes
Related to openverse #267 by @sarayourfriend
Description
This pull request Adds concurrency settings for workflow
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin