Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Retire TSV loading workflow #789

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Conversation

AetherUnbound
Copy link
Contributor

@AetherUnbound AetherUnbound commented Oct 10, 2022

Fixes

Fixes WordPress/openverse#1542 by @stacimc

Description

This PR retires the tsv_to_postgres_loader DAG, since it is no longer used in any of our ingestion workflows 🎉 I've also removed some no-obsolete code related to TSV pathing - this is covered by the DAG's XComs in the way our current pipelines are set up.

Testing Instructions

  1. just test
  2. Run both regular and legacy provider DAG scripts and check that records still make their way into the database (I tried SMK, Brooklyn, and Jamendo)
  3. Ensure that the tsv_to_postgres_workflow doesn't show up in your DAGs list locally.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner October 10, 2022 21:49
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 10, 2022
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Tested Smithsonian and Stocksnap just to be thorough. Great!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested the WordPress Photo Directory script and it loads rows in the image table 👍

Comment on lines -539 to -543
## `tsv_to_postgres_loader`

#### Database Loader DAG
**DB Loader Apache Airflow DAG** (directed acyclic graph) takes the media data saved
locally in TSV files, cleans it using an intermediate database table, and saves
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ask if we don't need to conserve this documentation but I see we have it where it was moved :)

#### Database Loader DAG
**DB Loader Apache Airflow DAG** (directed acyclic graph) takes the media data saved
locally in TSV files, cleans it using an intermediate database table, and saves
the cleaned-up data into the main database (also called upstream or Openledger).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made sure to check that as well 😄 Should have made a note in the description, apologies!

@AetherUnbound AetherUnbound merged commit 63b0fb7 into main Oct 17, 2022
@AetherUnbound AetherUnbound deleted the feature/retire-tsv-loading#548 branch October 17, 2022 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger TSV loading in ingestion workflow DAGs
4 participants