Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Standardize Airflow Variable names to uppercase #801

Conversation

davcortez
Copy link
Contributor

@davcortez davcortez commented Oct 16, 2022

Fixes

Fixes WordPress/openverse#1507 by @AetherUnbound

Description

  • Standardize the following Airflow Variable names to uppercase: slack_message_override, silenced_slack_notifications, environment, ingestion_limit
  • Update the references to the lower case Variables mentioned that appear within documentation.

Testing Instructions

Run just test

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@davcortez davcortez requested a review from a team as a code owner October 16, 2022 14:19
@openverse-bot openverse-bot added 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase labels Oct 16, 2022
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've searched the repository, and couldn't find any lower-case variable names. Great that the docs are also fixed! Thank you for your contribution, @davcortez !

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for making this change to both the documentation and the code! Congrats on your first contribution 😄

@AetherUnbound AetherUnbound merged commit b13390f into WordPress:main Oct 20, 2022
@davcortez
Copy link
Contributor Author

Thanks @AetherUnbound @obulat

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Airflow Variable names
4 participants