Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Refactor WordPress to use ProviderDataIngester #835

Merged
merged 6 commits into from
Oct 28, 2022

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes WordPress/openverse#1508 by @stacimc

Description

This PR refactors the WordPress Photo Directory provider script to use the ProviderDataIngester class. Since this was one of our more recent provider additions, it was already fairly closely aligned with our general layout now! I removed all of the boilerplate functions the class now handles, and most of the remaining functions did not need significant updates.

Testing Instructions

  1. just test
  2. Run the workflow locally and ensure that data gets inserted into the catalog.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner October 25, 2022 19:57
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon labels Oct 25, 2022
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested locally and everything is good 👍 Plus it's nice to see so much cleanup around the delayed requester 😄

Other than a quick comment about required field's and @obulat's suggestion to remove the filetype, I think this is good to go!

@AetherUnbound
Copy link
Contributor Author

AetherUnbound commented Oct 26, 2022

@obulat @stacimc removed the filetype extraction and addressed other feedback, this should be ready for another review!

Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@zackkrida zackkrida requested a review from obulat October 27, 2022 20:47
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one note but totally not a blocker 🏎️

@AetherUnbound AetherUnbound force-pushed the feature/wp-photo-dir-refactor#599 branch from 31c5cd5 to 5ba9cd6 Compare October 28, 2022 00:18
@AetherUnbound AetherUnbound merged commit 33c29f2 into main Oct 28, 2022
@AetherUnbound AetherUnbound deleted the feature/wp-photo-dir-refactor#599 branch October 28, 2022 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor WordPress provider script to use ProviderDataIngester
5 participants