This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Refactor WordPress to use ProviderDataIngester
#835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
✨ goal: improvement
Improvement to an existing user-facing feature
💻 aspect: code
Concerns the software code in the repository
🟨 priority: medium
Not blocking but should be addressed soon
labels
Oct 25, 2022
obulat
reviewed
Oct 26, 2022
openverse_catalog/dags/providers/provider_api_scripts/wordpress.py
Outdated
Show resolved
Hide resolved
obulat
reviewed
Oct 26, 2022
openverse_catalog/dags/providers/provider_api_scripts/wordpress.py
Outdated
Show resolved
Hide resolved
stacimc
reviewed
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tested locally and everything is good 👍 Plus it's nice to see so much cleanup around the delayed requester 😄
Other than a quick comment about required field's and @obulat's suggestion to remove the filetype
, I think this is good to go!
openverse_catalog/dags/providers/provider_api_scripts/wordpress.py
Outdated
Show resolved
Hide resolved
stacimc
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
sarayourfriend
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one note but totally not a blocker 🏎️
AetherUnbound
force-pushed
the
feature/wp-photo-dir-refactor#599
branch
from
October 28, 2022 00:18
31c5cd5
to
5ba9cd6
Compare
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟨 priority: medium
Not blocking but should be addressed soon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes WordPress/openverse#1508 by @stacimc
Description
This PR refactors the WordPress Photo Directory provider script to use the
ProviderDataIngester
class. Since this was one of our more recent provider additions, it was already fairly closely aligned with our general layout now! I removed all of the boilerplate functions the class now handles, and most of the remaining functions did not need significant updates.Testing Instructions
just test
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin