This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Only report DAG sync when DAG files have changed #872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #871 recently got reported to our Slack channel when it was deployed, even though it doesn't have any change to operational DAG code. This appears to be because we were only searching for
/dags/
in the path string, and that also includes changes to DAG tests only. This PR changes the DAG sync messaging so it only reports after changes to actual operational DAG code are deployed.Testing Instructions
Merge and see!
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin