Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify pre-commit config across repos #330

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Unify pre-commit config across repos #330

merged 4 commits into from
Nov 15, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 11, 2022

Fixes

Fixes #316 by @dhruvkb

Description

This PR improves the pre-commit sync by importing bits from the API and the catalog and then configures the sync action to push the changes downstream.

It is accompanied by two other PRs which should be merged before this one.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner November 11, 2022 06:05
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase labels Nov 11, 2022
@dhruvkb dhruvkb added the ⛔ status: blocked Blocked & therefore, not ready for work label Nov 11, 2022
@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 12, 2022

Integration of the frontend with this repository is pending BetaHuhn/repo-file-sync-action#271. We could theoretically use the action from dhruvkb/repo-file-sync-action if the PR is not merged but I would definitely love if @BetaHuhn accepts the PR and I don't need to maintain my fork.

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruvkb dhruvkb removed the ⛔ status: blocked Blocked & therefore, not ready for work label Nov 14, 2022
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice; lgtm.

@dhruvkb dhruvkb merged commit 50d4d68 into main Nov 15, 2022
@dhruvkb dhruvkb deleted the one_true_lint branch November 15, 2022 15:14
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
* Use retry library to catch and retry SSLErrors

* Add test for retry condition

* Pin retry version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync .pre-commit-config.yaml from this repo
4 participants