Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance for managing Performance feature plugins #1734

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Add guidance for managing Performance feature plugins #1734

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c77386
Add guidance for managing Performance feature plugins
ShyamGadde Dec 11, 2024
8f670f5
Replace hardcoded URL with `add_query_arg()`
ShyamGadde Dec 11, 2024
7b83127
Refactor plugins screen message to use `wp_kses`
ShyamGadde Dec 12, 2024
a7e0893
Merge branch 'trunk' into add/performance-features-management-guidance
ShyamGadde Dec 12, 2024
a152e45
Merge branch 'trunk' into add/performance-features-management-guidance
westonruter Dec 15, 2024
70b51ba
Only show plugin management link to authorized users
ShyamGadde Dec 16, 2024
a8f1c88
Merge branch 'trunk' into add/performance-features-management-guidance
ShyamGadde Dec 16, 2024
0aadb1e
Resolve PHP opening tag and whitespace violations
ShyamGadde Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions plugins/performance-lab/includes/admin/plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,16 @@ static function ( string $error_message ): string {
</div>
<div class="clear"></div>
</div>
<p>
westonruter marked this conversation as resolved.
Show resolved Hide resolved
<?php
printf(
/* translators: %1$s: opening anchor tag, %2$s: closing anchor tag */
esc_html__( 'Performance features are installed as plugins. To update features or remove them, %1$s manage them on the plugins screen. %2$s', 'performance-lab' ),
'<a href="' . esc_url( admin_url( 'plugins.php?s=WordPress%20Performance%20Team&plugin_status=all' ) ) . '">',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use add_query_arg() here instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8f670f5.

'</a>'
);
?>
</p>
<?php
}

Expand Down
Loading