Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground block UX improvements #136

Merged
merged 32 commits into from
Jan 16, 2024
Merged

Playground block UX improvements #136

merged 32 commits into from
Jan 16, 2024

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Dec 23, 2023

What?

  • Updates Playground packages versions
  • Wraps modal forms with HTML <form> tags to make the enter key work and adds autofocus
  • Wraps activatePlugin and handleCodeInjection with try/catch to prevent crashes in the editor (TODO – investigate the root cause of these crashes)

Demo:

Playground.block.mp4

Remaining work

Testing Instructions

Run the development build of the Playground block:

nx dev wordpress-playground-block

This will start:

  • A webpack development server for the wordpress-playground-block package
  • A new WordPress site with the wordpress-playground-block plugin activated

From here, play with the block, confirm the code editor works, the data is saved and rendered as expected, and that the block works in general.

wordpress-playground-block.zip

cc @dawidurbanski

@adamziel adamziel added Enhancement New feature or request Playground block labels Dec 23, 2023
@adamziel adamziel marked this pull request as draft December 23, 2023 23:05
@adamziel
Copy link
Collaborator Author

adamziel commented Dec 25, 2023

@adamziel adamziel marked this pull request as ready for review January 9, 2024 11:18
@adamziel adamziel merged commit e7c1912 into trunk Jan 16, 2024
2 checks passed
@adamziel adamziel deleted the playground-demo-i2 branch January 16, 2024 12:40
johnhooks pushed a commit to johnhooks/playground-tools that referenced this pull request Oct 11, 2024
* Indicate default username and password on `wp-login.php`

* Use a named file instead of `my-hacks.php`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Playground block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant