Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

Can we remove jQuery dependency? #12

Closed
joyously opened this issue Sep 6, 2019 · 4 comments
Closed

Can we remove jQuery dependency? #12

joyously opened this issue Sep 6, 2019 · 4 comments

Comments

@joyously
Copy link

joyously commented Sep 6, 2019

Would it be possible to rewrite the script in vanilla JS?

$js_dependencies = array( 'jquery' );

@carolinan
Copy link
Contributor

The plan is to remove jQuery yes.

@LittleBigThing
Copy link
Contributor

LittleBigThing commented Sep 8, 2019

This seems to be a fair amount of work, but of course needed.

Is there a plan on how to do this? Maybe we can start summarising the JS driven stuff in this issue and split them out in separate tasks?

  • Mobile menu toggle
  • Search toggle
  • Smooth scroll if needed
  • ...

Also, we could start the modifications based on the _s theme's vanilla JS files.

@sgomes
Copy link
Contributor

sgomes commented Sep 12, 2019

I'm planning to experiment with a simpler alternative to #101 that skips the build process and implements everything in vanilla ES5. If that turns out to be feasible, it would offer what I expect would be a good developer experience tradeoff: no newer JS features, but easier setup / getting started experience, with no tools involved.

Having two concrete PRs to look at would be a good way of reasoning about which approach we'd rather take, I expect, and I'm always happy to write code and have it thrown it away if it helps to reach a decision 🙂

carolinan added a commit that referenced this issue Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants