Use $wpdb instead in lock test.

WordPress · Oct 17, 2023 · 77e8e3a · 77e8e3a
1 parent c19d7d8
commit 77e8e3a
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/tests/phpunit/tests/admin/wpUpgrader.php b/tests/phpunit/tests/admin/wpUpgrader.php
@@ -1460,7 +1460,20 @@ public function test_maintenance_mode_should_create_maintenance_file_with_boolea
 	 * @covers WP_Upgrader::release_lock
 	 */
 	public function test_release_lock_should_remove_lock_option() {
-		update_option( 'lock.lock', 'content' );
+		global $wpdb;
+
+		$this->assertSame(
+			1,
+			$wpdb->insert(
+				$wpdb->options,
+				array(
+					'option_name'  => 'lock.lock',
+					'option_value' => 'content',
+				),
+				'%s'
+			),
+			'The initial lock was not created.'
+		);
 
 		WP_Upgrader::release_lock( 'lock' );
 
@@ -1480,14 +1493,14 @@ public function test_download_package_should_exit_early_when_the_upgrader_pre_do
 
 		add_filter(
 			'upgrader_pre_download',
-			static function ( $reply ) {
-				return ! $reply;
+			static function () {
+				return 'a non-false value';
 			}
 		);
 
 		$result = self::$instance->download_package( 'package' );
 
-		$this->assertTrue( $result );
+		$this->assertSame( 'a non-false value', $result );
 	}
 
 	/**