Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color merging algorithm #1289

Closed
wants to merge 1 commit into from
Closed

Update color merging algorithm #1289

wants to merge 1 commit into from

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented May 24, 2021

Part of https://core.trac.wordpress.org/ticket/53175

Follow up to #1262 which landed in ef3da33

The npm packages in use were published a few hours ago, which include some changes to how we manage colors. This PR adds the corresponding PHP changes.

How to test

This fixes this issue.

  • Use the latest wordpress-develop
  • Update and install the Gutenberg plugin from this branch.
  • Install and activate tt1 blocks from the theme install screen (installs from the theme's repo, not GitHub).
  • Observe the color palette contains only the theme palette.

@oandregal
Copy link
Member Author

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jorgefilipecosta
Copy link
Member

Committed in 73bf1da this PR should be closed.

@oandregal oandregal deleted the update/color-merging-algorithm branch May 31, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants