Add menus rest api endpoints. #1814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
spacedmonkey
force-pushed
the
fix/menu-endpoints
branch
from
bcd4d19 to
15f71c4
Compare
spacedmonkey
commented
Nov 8, 2021
spacedmonkey
force-pushed
the
fix/menu-endpoints
branch
from
6c790bf to
5410fba
Compare
TimothyBJacobs
force-pushed
the
fix/menu-endpoints
branch
2 times, most recently
from
bea1082 to
c7e2c02
Compare
Set cap type and meta cap mapping Restore original error messages. Fix invalid menu location error code. More test fixes.
- Tests cleanup: Use assertSame, follow naming conventions. - Doc block and comment fixes. - Ensure parameter types/names and return types are consistent when extending base classes. - Type out doc blocks for menu items filters since they don't match the signature because they pass the prepared menu item instead of a `WP_Post` object. - Don't duplicate validation and sanitization that happens at the schema level. - Use JSON schema multi-type support instead of disabling validation/sanitization. Fix test CS issue A bit more docblock cleanup.
TimothyBJacobs
force-pushed
the
fix/menu-endpoints
branch
from
c7e2c02 to
cd07b8f
Compare
Enabling batching is handled by Core now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature plugin - https://github.com/WP-API/menus-endpoints
Trac ticket: https://core.trac.wordpress.org/ticket/40878
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.