Reapply appearance-tools theme support from #3846 #5813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
remove instead of add Co-authored-by: Andrew Serong <[email protected]>
There was a problem hiding this comment.
Thanks @tellthemachines for the PR. Left some nit-pick feedbacks.
Remove space Co-authored-by: Mukesh Panchal <[email protected]>
Add quotes around feature name. Co-authored-by: Mukesh Panchal <[email protected]>
|
Thanks for the reviews folks! All changes have been made. |
noisysocks
approved these changes
Jan 9, 2024
mukeshpanchal27
approved these changes
Jan 9, 2024
|
Thanks for the reviews folks! Committed in r57255. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/60118
I just copied over the changes from #3846 as that patch was no longer applying cleanly.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.