Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Refactor to use string instead of an object #6111

Conversation

cbravobernal
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/60542

Gutenberg backport: WordPress/gutenberg#59030


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Feb 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props cbravobernal, gziolo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@gziolo
Copy link
Member

gziolo commented Feb 15, 2024

What was the original ticket where the same functionality landed? It would be better to link it instead when refactoring code unless it's a bug. Still, we would need the original commit and ticket to reference in the commit message.

@cbravobernal
Copy link
Contributor Author

cbravobernal commented Feb 15, 2024

The code that implements that change is part of the interactivity package, that landed in 17.7

Was implemented here:

And commited in this ticket:

Edit:
The ticket that included the PHP supporting both the object and the string, and the router.
https://core.trac.wordpress.org/ticket/60356

@cbravobernal cbravobernal changed the title Refactor to use string instead of an object Interactivity API: Refactor to use string instead of an object Feb 15, 2024
@swissspidy
Copy link
Member

@swissspidy swissspidy closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants