Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync packages for WordPress 6.7.1 RC1 #7851

Closed
wants to merge 2 commits into from
Closed

Sync packages for WordPress 6.7.1 RC1 #7851

wants to merge 2 commits into from
+293 −219

Conversation

cbravobernal
Copy link
Contributor

@cbravobernal cbravobernal commented Nov 20, 2024 •
edited
Loading

Syncs Editor packages for WordPress 6.7.1 RC1. Includes the following PRs:

Packages being updated:

 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]

Trac ticket: https://core.trac.wordpress.org/ticket/62478

Props:
matiasbenedetto, ramonjd, mamaduka, getdave, poena, ntsekouras, mcsf, jsnajdr, mirka, desrosj, joemcgill, cbravobernal, azaozz, room34, mayanktripathi32, im3dabasia1, jonsurrell
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@cbravobernal cbravobernal requested a review from desrosj November 20, 2024 14:48
@cbravobernal cbravobernal self-assigned this Nov 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props cbravobernal, jonsurrell, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal
Copy link
Member

sirreal commented Nov 20, 2024

It looks like this needs src/wp-includes/assets/script-loader-packages.min.php to be compiled and committed.

@cbravobernal
Copy link
Contributor Author

It looks like this needs src/wp-includes/assets/script-loader-packages.min.php to be compiled and committed.

Yep, just updated it.

sirreal
sirreal approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks reasonable. I did some light smoke testing in the editor and did not observe any issues.

@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Nov 20, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Nov 20, 2024
@desrosj desrosj mentioned this pull request Nov 20, 2024
Open
@cbravobernal cbravobernal changed the base branch from 6.7 to trunk November 20, 2024 15:45
@cbravobernal cbravobernal changed the base branch from trunk to 6.7 November 20, 2024 15:47
@cbravobernal
Copy link
Contributor Author

Committed in https://core.trac.wordpress.org/changeset/59437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

@desrosj desrosj desrosj approved these changes

Assignees

@cbravobernal cbravobernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbravobernal @sirreal @desrosj