Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update demo on-page notification messages #68

Closed
jonathanbossenger opened this issue Jun 1, 2022 · 0 comments
Closed

Update demo on-page notification messages #68

jonathanbossenger opened this issue Jun 1, 2022 · 0 comments
Labels
demo

Comments

@jonathanbossenger
Copy link
Collaborator

In preparation for the demo

Can we update the lipsum text, to something that is more descriptive, and also describes the message variant being displayed? For example, for the top notification, it could be something like:

This is an example of on-page message variant #1. It has a title, a message, an action button with a URL, is dismissable, and has an image. To see the notification hub messages, click on the bell icon on the right side of the admin bar 😉.
erikyo added a commit to erikyo/wp-feature-notifications that referenced this issue Jun 1, 2022
@erikyo
Fixes WordPress#68 - updates the fake notifications messages and titl…
308b8f6 
…e with something of more descriptive (additionally removes the delay to the first notification)
jonathanbossenger added a commit that referenced this issue Jun 2, 2022
@jonathanbossenger
Merge pull request #71 from erikyo/issue68/notification-messages
5f6c4e9 
Fixes #68 - Updates the fake notifications messages and title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
demo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathanbossenger