Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo REST controller #117

Merged
merged 6 commits into from
Dec 21, 2022
Merged

Add demo REST controller #117

merged 6 commits into from
Dec 21, 2022

Conversation

Sephsekla
Copy link
Collaborator

@Sephsekla Sephsekla commented Oct 26, 2022

What?

This PR adds a demo REST Controller for fetching notifications.

Why?

This allows us to move the demo content to the PHP side, allowing real js querying of the endpoint.

How?

Testing Instructions

Screenshots or screencast

@Sephsekla
Copy link
Collaborator Author

Hmm, looks like an issue with PHPCS now, don't think it's related to my code but I'll take a look later.

@erikyo
Copy link
Collaborator

erikyo commented Nov 2, 2022

I think we need to add
excludes: 'tests/'

into actions WPCS action template. (check here)

@Sephsekla
Copy link
Collaborator Author

I think we need to add excludes: 'tests/'

into actions WPCS action template. (check here)

Hmm, weird that this test passed on the previous commit though.

@erikyo
Copy link
Collaborator

erikyo commented Nov 3, 2022

indeed i was wrong, it is not an issue of with excluded paths and looking closely even files inside "./includes/" have the same problem.

if you have the time try updating wpcs, the one we are using is an old version

@Sephsekla Sephsekla marked this pull request as ready for review December 7, 2022 16:44
@Sephsekla Sephsekla merged commit b585236 into develop Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants