Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hides /src/stories/assets and package.json from linguist #146

Merged
merged 4 commits into from
Jan 25, 2023
Merged

hides /src/stories/assets and package.json from linguist #146

merged 4 commits into from
Jan 25, 2023

Conversation

erikyo
Copy link
Collaborator

@erikyo erikyo commented Jan 20, 2023 •
edited
Loading

What?

Exclude vendored and generated files

Why?

#138

How?

added to .gitattributes this content

# exclude vendored and generated files
package.json linguist-generated=true
/src/stories/assets/** linguist-vendored=true

close #138

@erikyo erikyo added the [Type] development tools Setting up and cofniguring tools to help with the development process. label Jan 20, 2023
@erikyo erikyo requested a review from Sephsekla January 20, 2023 13:18
Sephsekla
Sephsekla reviewed Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@Sephsekla Sephsekla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding package-lock.json as well?

.gitattributes Outdated Show resolved Hide resolved
@erikyo erikyo requested a review from Sephsekla January 24, 2023 12:04
Sephsekla
Sephsekla previously approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@Sephsekla Sephsekla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on the package-lock suggestion? Good to go either way.

@erikyo erikyo merged commit bb1951b into WordPress:develop Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sephsekla Sephsekla Sephsekla approved these changes

Assignees
No one assigned
Labels
[Type] development tools Setting up and cofniguring tools to help with the development process.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the .gitattributes in order to hide some folders/files from linguist
2 participants
@erikyo @Sephsekla