Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .nvmrc file #169

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix .nvmrc file #169

merged 1 commit into from
Mar 22, 2023

Conversation

Sephsekla
Copy link
Collaborator

@Sephsekla Sephsekla commented Mar 20, 2023 •
edited
Loading

What?

Recreate .nvmrc file due to encoding issues. I've gone with lts/gallium for now, as the build seems to work fine with this, however we can revisit the exact version down the line.

Why?

See #166

How?

  • Delete old .nvmrc file entirely
  • Create new .nvmrc file

Testing Instructions

  • Use nvm to set correct node version
  • Check for successful build

Screenshots or screencast

@Sephsekla Sephsekla self-assigned this Mar 20, 2023
@Sephsekla Sephsekla requested a review from erikyo March 20, 2023 10:09
erikyo
erikyo reviewed Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think it would be better to use the LTS as a target? In this way we can also avoid updating this file

@Sephsekla
Copy link
Collaborator Author

Don't you think it would be better to use the LTS as a target? In this way we can also avoid updating this file

Hmm, it's a fair point. On the other hand I'd argue that switching the node version should be something that we deliberately do when the time comes.

erikyo
erikyo approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sephsekla Sephsekla merged commit 6b42441 into develop Mar 22, 2023
@Sephsekla Sephsekla deleted the 166-nvmrc-encoding branch March 22, 2023 12:11
@erikyo erikyo mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikyo erikyo erikyo approved these changes

Assignees

@Sephsekla Sephsekla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sephsekla @erikyo